[SPIRV] Treat vk::Spirv*Type as opaque when reconstructing#7454
Merged
s-perron merged 2 commits intomicrosoft:mainfrom May 15, 2025
Merged
[SPIRV] Treat vk::Spirv*Type as opaque when reconstructing#7454s-perron merged 2 commits intomicrosoft:mainfrom
s-perron merged 2 commits intomicrosoft:mainfrom
Conversation
It is possible to have two struct types in spir-v that are the same except for the decorations. Sometimes we have to reconstruct the value from one type to another. In the case of a vk::SpirvType, we do not know anything about the type, so this should not happen. When trying to reconstuct the value, we should simply return the original value. Fixes microsoft#6963
amaiorano
approved these changes
May 14, 2025
Collaborator
amaiorano
left a comment
amaiorano
left a comment
There was a problem hiding this comment.
The semantics are beyond my depth, but codewise, it looks good to me.
cassiebeckley
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible to have two struct types in spir-v that are the same
except for the decorations. Sometimes we have to reconstruct the value
from one type to another.
In the case of a vk::SpirvType, we do not know anything about the type,
so this should not happen. When trying to reconstuct the value, we
should simply return the original value.
Fixes #6963